feat(q7): add set_button_lights trait method - #843
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds support for toggling the Q7 button/panel light setting via the Q7 properties API, along with test coverage to validate the generated prop.set payload.
Changes:
- Introduced
set_button_light(enabled: bool)onQ7PropertiesApito setRoborockB01Props.LIGHT_MODEto0/1. - Added a parametrized test that validates the outgoing DPS payload for both enabled/disabled states.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/devices/traits/b01/q7/test_init.py | Adds a new parametrized test asserting correct DPS payload when toggling button lights |
| roborock/devices/traits/b01/q7/init.py | Adds set_button_light() method wiring to LIGHT_MODE via set_prop |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cf37c6b to
277742c
Compare
277742c to
a6b920b
Compare
|
Converting to draft given changes are requested. Mark ready for review when they've been addressed. |
a6b920b to
f24ea7b
Compare
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
f24ea7b to
a5c888e
Compare
I'm assuming its ready since the last force push? will review now. marking as ready for review. |
|
Oh I see the naming discussion was not settled.... |
allenporter
left a comment
allenporter
left a comment
There was a problem hiding this comment.
Marking request changes to help with tracking w.r.t. set_button_lights
The setting toggles multiple button lights, so the plural name matches
what the app calls it ("Button Lights"), as agreed in review.
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
ximex
changed the title
Summary
Adds
set_button_lights(enabled)to the Q7 (B01) trait, toggling the panel /button lights via
prop.setforRoborockB01Props.LIGHT_MODE(0/1).Part of #739.
Verification
ruffclean.